Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for pnpm #79

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Adds support for pnpm #79

merged 1 commit into from
Jul 25, 2022

Conversation

scalvert
Copy link
Collaborator

Implements #70

@scalvert scalvert requested a review from rwjblue July 21, 2022 19:21
@scalvert
Copy link
Collaborator Author

cc/ @NullVoxPopuli

@rwjblue rwjblue added the enhancement New feature or request label Jul 25, 2022
@scalvert scalvert merged commit d29587f into master Jul 25, 2022
@scalvert scalvert deleted the support-pnpm branch July 25, 2022 21:30
@NullVoxPopuli
Copy link
Contributor

it seems like this doesn't quite work right 🤔 it removes the workspace:* protocol from packages -- which is needed for tag-pushing workflows, like we have in glimmer-vm: https://github.com/glimmerjs/glimmer-vm/blob/master/.github/workflows/release.yml#L31

@NullVoxPopuli NullVoxPopuli mentioned this pull request Oct 13, 2023
Merged
@TimoGlastra TimoGlastra mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scalvert @NullVoxPopuli @rwjblue