Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to esm #19

Merged
merged 1 commit into from
Jan 16, 2022
Merged

Conversation

jairhenrique
Copy link
Contributor

@webpro I don't know why it's failing the tests.

⟩ npm test

> @release-it/bumper@3.0.1 test
> bron test.js

✔ should not write in dry run
✔ should not throw
✔ should write new, indented JSON file
✔ should write version at path
✔ should write version at multiple paths
✔ should write plain version text file
✔ should write plain version text file (default text type)
fish: Job 1, 'npm test' terminated by signal SIGABRT (Abort)

Copy link

@matheusrufinos matheusrufinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@jairhenrique
Copy link
Contributor Author

Fixed all erros!
Screen Shot 2021-12-20 at 14 45 45

@jairhenrique
Copy link
Contributor Author

@webpro can you review this!?

@webpro
Copy link
Contributor

webpro commented Jan 16, 2022

Thanks @jairhenrique! The updates looks great, just two things:

  • I've added the Prettier config in the master branch, could you please apply the same styling again?
  • I've added the feature/es-modules branch in my repo. Can you point this PR to that branch? Then I can make pre-releases from there first.

Thanks again for all the work :)

@jairhenrique jairhenrique changed the base branch from master to feature/es-modules January 16, 2022 10:32
@jairhenrique
Copy link
Contributor Author

@webpro done!

@webpro webpro merged commit b42e830 into release-it:feature/es-modules Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants