Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST-API server and client added, timeset capability #14

Merged
merged 87 commits into from
Mar 2, 2022
Merged

REST-API server and client added, timeset capability #14

merged 87 commits into from
Mar 2, 2022

Conversation

niemsoen
Copy link

No description provided.

niemsoen and others added 30 commits September 30, 2021 12:52
@niemsoen
initial commit: added restapi state of work
9279d6c
@relffok
Merge pull request #9 from niemsoen/foxy-devel
b542011 
Added headless launch file to mir_driver
@niemsoen
added mir_ready publisher
2a0dde8
@niemsoen
Merge pull request #1 from niemsoen/adding-mirbridge-ready-signal
6093bb8 
added mir_bridge_ready publisher
@niemsoen
added reliable QOS for mir_bridge_ready topic
7cf0903
@niemsoen
added mir_bridge_ready=false on crash/shutdown
4fe0c37
@niemsoen
attribute bugfix
02ee545
@niemsoen
added readiness polling and simplified ready publishing
137c7a5
@niemsoen
uneccesary main->publish_mir_ready_state: button checks bridge alive
f2d0e04
@niemsoen
uneccesary main->publish_mir_ready_state: button checks bridge alive
ab51022
@niemsoen
Merge branch 'galactic-devel' of https://github.com/niemsoen/mir_robot …
39e025e 
…into galactic-devel
@niemsoen
changed mir_ready pub/sub to Trigger-service
1ba188c
@niemsoen
possible bugfix
e91279e
@niemsoen
changed response to success=True always and message=True/False
f31efb8
@niemsoen
Revert "changed response to success=True always and message=True/False"
6e00df4 
This reverts commit f31efb8.
@niemsoen
Merge branch 'relffok:foxy-devel' into mir-bridge-as-service-server
9dbda46
@niemsoen
added custom CheckReady srv-definition
c84ccb6
@niemsoen
Merge branch 'mir-bridge-as-service-server' of https://github.com/nie…
d7a1eb2 
…msoen/mir_robot into mir-bridge-as-service-server
@niemsoen
find bug in service
691f574
@niemsoen
renamed interface to match usb_pushbutton
34cb67c
@niemsoen
fixed dependency
eb07640
@niemsoen
fixed another dependency
28b8218
@niemsoen
Merge pull request #2 from niemsoen/mir-bridge-as-service-server
cf0f5c1 
Mir bridge as service server
Revert "Merge pull request #2 from niemsoen/mir-bridge-as-service-ser…
69de4f7 
…ver"

This reverts commit cf0f5c1, reversing
changes made to 39e025e.
Use std_srvs/Trigger as mir-ready-service Type
bb0eba0
@niemsoen
Merge branch 'relffok:galactic-devel' into galactic-devel
49e035d
@niemsoen
Merge branch 'galactic-devel' into implementing-restapi-client
e1564f1
@niemsoen
changed structure to service-client communication
cbd49ee
@niemsoen
fix for build error?
f93c28b
@niemsoen
wrong directory name
701a0db
niemsoen and others added 3 commits January 26, 2022 14:06
@niemsoen
Merge pull request #4 from niemsoen/mir-restapi-launch-no-apitoken-bu…
788a739 
…gfix

Launch mir_restapi_server in external driver
@niemsoen
Added api-call abstarction layer & tested api call while bridge conne…
2683c2b 
…cted (#5)
@niemsoen
init (#6)
3083ba7 
Co-authored-by: Sönke Niemann <soenke.niemann@ipk.fraunhofer.de>
@relffok
Copy link
Owner

relffok commented Feb 2, 2022

Thanks for the adaptions, could you add a short how-to in the README section where the time synchronization is mentioned?

@niemsoen
Copy link
Author

niemsoen commented Feb 3, 2022

Added the readme section with guide to sync time in ros and removed the automatic time sync call at startup of mir_driver

@niemsoen
Copy link
Author

niemsoen commented Feb 3, 2022

did some housekeeping, now it's ready for merge :)

@niemsoen
Copy link
Author

niemsoen commented Mar 1, 2022

Hey, I resolved the conflicts, that came up recently :)

relffok
relffok reviewed Mar 2, 2022
View reviewed changes
Copy link
Owner

@relffok relffok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was finally able to check this on the real robot. Looks good to me! Only minimal comments. Thanks!

mir_driver/mir_driver/mir_bridge.py Outdated Show resolved Hide resolved
mir_driver/package.xml Outdated Show resolved Hide resolved
mir_restapi/package.xml Show resolved Hide resolved
mir_restapi/mir_restapi/mir_restapi_lib.py Outdated Show resolved Hide resolved
@niemsoen
Copy link
Author

niemsoen commented Mar 2, 2022

Okay put requested changes into PR

@relffok relffok merged commit b96e3e4 into relffok:galactic-devel Mar 2, 2022
@mintar mintar mentioned this pull request Sep 19, 2022
Closed
mintar pushed a commit to mintar/mir_robot that referenced this pull request Sep 29, 2022
@niemsoen @relffok @mintar
REST-API server and client added, timeset capability
8139109 
See relffok#14

Co-authored-by: relffok <57466265+relffok@users.noreply.github.com>
Co-authored-by: soenke.niemann <s.niemann@campus.tu-berlin.de>
Co-authored-by: Niemann <soenke.niemann@ipk.fraunhofer.de>
Co-authored-by: Sönke Niemann <soenke.niemann@wtnet.de>
mintar pushed a commit to mintar/mir_robot that referenced this pull request Oct 11, 2022
@niemsoen @relffok @mintar
REST-API server and client added, timeset capability
c844b61 
See relffok#14

Co-authored-by: relffok <57466265+relffok@users.noreply.github.com>
Co-authored-by: soenke.niemann <s.niemann@campus.tu-berlin.de>
Co-authored-by: Niemann <soenke.niemann@ipk.fraunhofer.de>
Co-authored-by: Sönke Niemann <soenke.niemann@wtnet.de>
mintar pushed a commit to mintar/mir_robot that referenced this pull request Oct 13, 2022
@niemsoen @relffok @mintar
REST-API server and client added, timeset capability
ea12ec3 
See relffok#14

Co-authored-by: relffok <57466265+relffok@users.noreply.github.com>
Co-authored-by: soenke.niemann <s.niemann@campus.tu-berlin.de>
Co-authored-by: Niemann <soenke.niemann@ipk.fraunhofer.de>
Co-authored-by: Sönke Niemann <soenke.niemann@wtnet.de>
mintar pushed a commit to mintar/mir_robot that referenced this pull request Oct 14, 2022
@niemsoen @relffok @mintar
REST-API server and client added, timeset capability
8211341 
See relffok#14

Co-authored-by: relffok <57466265+relffok@users.noreply.github.com>
Co-authored-by: soenke.niemann <s.niemann@campus.tu-berlin.de>
Co-authored-by: Niemann <soenke.niemann@ipk.fraunhofer.de>
Co-authored-by: Sönke Niemann <soenke.niemann@wtnet.de>
mintar pushed a commit to mintar/mir_robot that referenced this pull request Oct 14, 2022
@niemsoen @relffok @mintar
REST-API server and client added, timeset capability
3a64ba5 
See relffok#14

Co-authored-by: relffok <57466265+relffok@users.noreply.github.com>
Co-authored-by: soenke.niemann <s.niemann@campus.tu-berlin.de>
Co-authored-by: Niemann <soenke.niemann@ipk.fraunhofer.de>
Co-authored-by: Sönke Niemann <soenke.niemann@wtnet.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relffok relffok relffok requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niemsoen @relffok