Make tasks markdown checkable. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a bit of instructions on creating a new issue when someone picks a task. The idea is we can use README to keep low hanging fruit available for people. Another option (maybe later, but much less visible) would be to create issues for each task and tag them as unasigned, by complexity and such. By now I guess it's a good idea to have them (while they are few) discoverable on the readme.
|
Looks good, thanks. Agreed, I imagine we'll reach a point where we just use GitHub issues for good first bugs. Still, at the moment the purpose of the readme is to make contributing seem straightforward and interesting :) |
Wilfred
approved these changes
Jan 12, 2017
jeandudey
pushed a commit
to jeandudey/remacs
that referenced
this pull request
May 29, 2017
The recent changes to src/casefiddle.c cause build failure as seen
below:
Starting program: /home/npostavs/src/emacs/emacs-bootstrapping/src/temacs
--batch --load loadup bootstrap
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
Loading loadup.el (source)...
Using load-path (/home/npostavs/src/emacs/emacs-bootstrapping/lisp
/home/npostavs/src/emacs/emacs-bootstrapping/lisp/emacs-lisp
/home/npostavs/src/emacs/emacs-bootstrapping/lisp/language
/home/npostavs/src/emacs/emacs-bootstrapping/lisp/international
/home/npostavs/src/emacs/emacs-bootstrapping/lisp/textmodes
/home/npostavs/src/emacs/emacs-bootstrapping/lisp/vc)
Loading emacs-lisp/byte-run (source)...
Loading emacs-lisp/backquote (source)...
Loading subr (source)...
Loading version (source)...
Loading widget (source)...
Loading custom (source)...
Loading emacs-lisp/map-ynp (source)...
Loading international/mule (source)...
Loading international/mule-conf (source)...
lread.c:3914: Emacs fatal error: assertion failed: !NILP (Vpurify_flag)
Breakpoint 1, terminate_due_to_signal at emacs.c:363
363 signal (sig, SIG_DFL);
(gdb) bt
#0 0x0000000000579826 in terminate_due_to_signal at emacs.c:363
remacs#1 0x000000000060ec33 in die at alloc.c:7352
remacs#2 0x000000000066db40 in intern_c_string_1 at lread.c:3914
remacs#3 0x0000000000576884 in intern_c_string at lisp.h:3790
remacs#4 0x00000000005dc84f in prepare_casing_context at casefiddle.c:69
remacs#5 0x00000000005dd37f in casify_object at casefiddle.c:311
remacs#6 0x00000000005dd47f in Fcapitalize at casefiddle.c:356
remacs#7 0x00000000006325ac in eval_sub at eval.c:2219
remacs#8 0x0000000000632368 in eval_sub at eval.c:2184
remacs#9 0x000000000063446c in apply_lambda at eval.c:2875
remacs#10 0x00000000006329af in eval_sub at eval.c:2294
remacs#11 0x000000000062d462 in Fprogn at eval.c:449
remacs#12 0x000000000062d4cf in prog_ignore at eval.c:461
remacs#13 0x000000000062f19c in Fwhile at eval.c:982
remacs#14 0x00000000006321f4 in eval_sub at eval.c:2172
remacs#15 0x000000000062d462 in Fprogn at eval.c:449
remacs#16 0x000000000062f0c4 in Flet at eval.c:963
remacs#17 0x00000000006321f4 in eval_sub at eval.c:2172
remacs#18 0x0000000000632963 in eval_sub at eval.c:2290
remacs#19 0x000000000062d462 in Fprogn at eval.c:449
remacs#20 0x000000000062f0c4 in Flet at eval.c:963
remacs#21 0x00000000006321f4 in eval_sub at eval.c:2172
remacs#22 0x0000000000668caa in readevalloop at lread.c:1927
remacs#23 0x0000000000667253 in Fload at lread.c:1332
remacs#24 0x0000000000632683 in eval_sub at eval.c:2233
remacs#25 0x0000000000668caa in readevalloop at lread.c:1927
remacs#26 0x0000000000667253 in Fload at lread.c:1332
remacs#27 0x0000000000632683 in eval_sub at eval.c:2233
remacs#28 0x0000000000631be5 in Feval at eval.c:2041
remacs#29 0x000000000057e1af in top_level_2 at keyboard.c:1121
remacs#30 0x000000000062ffc7 in internal_condition_case at eval.c:1324
remacs#31 0x000000000057e1f0 in top_level_1 at keyboard.c:1129
remacs#32 0x000000000062f51e in internal_catch at eval.c:1091
remacs#33 0x000000000057e0ea in command_loop at keyboard.c:1090
remacs#34 0x000000000057d6d5 in recursive_edit_1 at keyboard.c:697
remacs#35 0x000000000057d8b4 in Frecursive_edit at keyboard.c:768
remacs#36 0x000000000057b55b in main at emacs.c:1687
Lisp Backtrace:
"capitalize" (0xffffcf70)
"format" (0xffffd130)
"define-charset" (0xffffd370)
"while" (0xffffd560)
"let" (0xffffd7c0)
"dolist" (0xffffd910)
"let" (0xffffdb70)
"load" (0xffffdfe0)
"load" (0xffffe4a0)
* src/casefiddle.c (syms_of_casefiddle): Declare four new symbols:
Qtitlecase, Qspecial_uppercase, Qspecial_lowercase and
Qspecial_titlecase.
(prepare_casing_context): Use aforementioned symbols.
db48x
pushed a commit
to db48x/remacs
that referenced
this pull request
Mar 7, 2018
Latest Terminfo introduces terminal definitions that support direct color mode. The "Co"/"colors" capability is set to 0x1000000 on these terminals and Emacs is already compatible with them. However, if used Terminfo library hasn't been compiled with 32-bit value support, "Co"/"colors" is truncated to 0x7fff. In this case direct color mode support can be detected from the "RGB" capability flag. There are some minor problems if the color count isn't corrected from 0x7fff. First eight standard colors defined in xterm-standard-colors are shown correctly. However, their RGB values match the terminal settings, not the RGB values defined in xterm-standard-colors. Bright versions of these colors are shown incorrectly. They are interpreted as pixels remacs#8 - remacs#15, which are very dark shades of blue. * src/term.c (init_tty): Force terminal color count to 0x1000000 if "RGB" capability is present. * src/tparam.h: Define prototype for tigetflag. (Bug#30308) * doc/misc/efaq.texi (Colors on a TTY): Add information about direct mode terminals supported by Terminfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a bit of instructions on creating a new issue when someone picks a task. The idea is we can use README to keep low hanging fruit available for people. Another option (maybe later, but much less visible) would be to create issues for each task and tag them as unasigned, by complexity and such.
By now I guess it's a good idea to have them (while they are few) discoverable on the readme.