Parser completely removes body elements if html string has open <html> and <body> tags, but does not have close </body> and tag #18
Labels
Comments
|
So, looks like the problem is here: |
|
Thanks for opening this issue (and closing remarkablemark/html-react-parser#126) @sanex3339 I can confirm that this is a bug. Along with your fiddle, I can reproduce that this happens on the client parser (see repl) and not on the server parser (see repl). Would you be interested in making a fix? Otherwise, I should have some time over the weekend to work on it. |
|
Hi, unfortunately, I haven't time to fix this bug, but I can wait until you'll fix it. |
|
No worries, I'll update you know once I have the fix. |
remarkablemark
added a commit
that referenced
this issue
Nov 4, 2019
Because the head and body regexes test against the closing tag,
this causes html with unclosed head or body to not be parsed
correctly.
For example, given the following:
```js
parse('<html><body>');
```
The expected output is:
```
[ { type: 'tag',
name: 'html',
attribs: {},
children:
[ { type: 'tag',
name: 'body',
attribs: {},
children: [],
next: null,
prev: null,
parent: [Circular] } ],
next: null,
prev: null,
parent: null } ]
```
But the actual output is:
```
[
{
"next": null,
"prev": null,
"parent": null,
"name": "html",
"attribs": {},
"type": "tag",
"children": []
}
]
```
The fix is to update the regex to use the opening tag instead of
the closing tag.
Add test case.
Fixes #18
|
# update with npm
npm i -S html-dom-parser@0.2.3
# or with yarn
yarn add html-dom-parser@0.2.3I'll have a followup PR for html-react-parser. |
remarkablemark
added a commit
to remarkablemark/html-react-parser
that referenced
this issue
Nov 4, 2019
html-dom-parser 0.2.2 → 0.2.3 This fixes a bug related to client-side DOM parsing for unclosed HTML markup. Relates to #126 and remarkablemark/html-dom-parser#18
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Parser should try to keep all existing html tags if html string has open and tags, but does not have close and tags
Actual Behavior
Parser completely removes all
htmlchildren elements if html string has open and tags, but does not have close tagSteps to Reproduce
Just try to parse following html string:
Reproducible Demo
https://jsfiddle.net/d2g59ch4/
Environment
The text was updated successfully, but these errors were encountered: