fix(dom-to-react): default props.children to undefined instead of null

remarkablemark · Oct 29, 2023 · a6978c3 · a6978c3
1 parent 57571aa
commit a6978c3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/__tests__/dom-to-react.test.tsx b/__tests__/dom-to-react.test.tsx
@@ -84,7 +84,7 @@ describe('domToReact', () => {
 
   it('does not have `children` for void elements', () => {
     const reactElement = domToReact(htmlToDOM(html.img)) as JSX.Element;
-    expect(reactElement.props.children).toBe(null);
+    expect(reactElement.props.children).toBe(undefined);
   });
 
   it('does not throw an error for void elements', () => {

diff --git a/src/dom-to-react.ts b/src/dom-to-react.ts
@@ -96,7 +96,7 @@ export default function domToReact(
       props = attributesToProps(element.attribs, element.name);
     }
 
-    let children = null;
+    let children;
 
     switch (node.type) {
       case 'script':