Error: Client parser breaks when first element has attributes #23

remarkablemark · 2016-09-27T15:39:46Z

When the client parser parses an HTML string where the first element has attribute(s), this causes the regex to match an improper tag name and throw an error on this line.

Example:

// works
HTMLReactParser('<p>foo</p>');

// breaks
HTMLReactParser('<p id="bar">foo</p>');

Error thrown:

TypeError: Cannot read property 'parentNode' of undefined

For the client parser, when the first element of the HTML string has attributes, the regex will improperly capture everything and make the tag name invalid. The fix is to ensure only the tag name is matched and whitespace is trimmed. Fixes #23

Confirm that for the client parser, if the first HTML element has attributes, it should properly match only the tag name and no longer throw an error. Issue #23

remarkablemark added the bug Something isn't working label Sep 27, 2016

remarkablemark self-assigned this Sep 27, 2016

remarkablemark changed the title ~~Error: Client-side parser breaks when root element has attributes~~ Error: Client parser breaks when first element has attributes Sep 27, 2016

remarkablemark mentioned this issue Sep 27, 2016

Fix regex bug on client parser #24

Merged

remarkablemark closed this as completed in #24 Sep 27, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error: Client parser breaks when first element has attributes #23

Error: Client parser breaks when first element has attributes #23

remarkablemark commented Sep 27, 2016 •

edited

Error: Client parser breaks when first element has attributes #23

Error: Client parser breaks when first element has attributes #23

Comments

remarkablemark commented Sep 27, 2016 • edited

remarkablemark commented Sep 27, 2016 •

edited