test: refactor and add missing tests, get coverage to 100% #156

remarkablemark · 2020-05-25T22:30:17Z

-------------------------|----------|----------|----------|----------|-------------------|
File                     |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
-------------------------|----------|----------|----------|----------|-------------------|
All files                |      100 |    97.85 |      100 |      100 |                   |
 html-react-parser       |      100 |      100 |      100 |      100 |                   |
  index.js               |      100 |      100 |      100 |      100 |                   |
 html-react-parser/lib   |      100 |     97.8 |      100 |      100 |                   |
  attributes-to-props.js |      100 |    95.65 |      100 |      100 |                85 |
  dom-to-react.js        |      100 |    97.44 |      100 |      100 |                38 |
  utilities.js           |      100 |      100 |      100 |      100 |                   |
-------------------------|----------|----------|----------|----------|-------------------|

This helps improve test coverage for `attributes-to-props.js`. Move empty style test to its own it block.

Since it does not provide any value as style is either undefined, null, or string.

This gets coverage to 100%.

coveralls · 2020-05-25T22:32:27Z

Coverage remained the same at 100.0% when pulling aeed1bf on test/coverage into d299826 on master.

Use `npx` so we can remove `coveralls` from devDependencies

remarkablemark · 2020-05-25T22:55:49Z

Published 0.10.4:

npm:

npm i html-react-parser@0.10.4 -S

yarn:

yarn add html-react-parser@0.10.4

remarkablemark added 4 commits May 25, 2020 18:23

test: tidy tests, replace assert.equal with assert.strictEqual

ef04eff

test(attributes-to-props): test that CSS comment is not parsed

0c27987

This helps improve test coverage for `attributes-to-props.js`. Move empty style test to its own it block.

refactor(attributes-to-props): remove string type check in cssToJs

77a108b

Since it does not provide any value as style is either undefined, null, or string.

test(dom-to-react): tidy tests and add case for single node replace

452f6be

This gets coverage to 100%.

ci(travis): move coveralls script from package.json to .travis.yml

aeed1bf

Use `npx` so we can remove `coveralls` from devDependencies

remarkablemark merged commit 74931e4 into master May 25, 2020

remarkablemark deleted the test/coverage branch May 25, 2020 22:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: refactor and add missing tests, get coverage to 100% #156

test: refactor and add missing tests, get coverage to 100% #156

remarkablemark commented May 25, 2020 •

edited

coveralls commented May 25, 2020 •

edited

remarkablemark commented May 25, 2020

test: refactor and add missing tests, get coverage to 100% #156

test: refactor and add missing tests, get coverage to 100% #156

Conversation

remarkablemark commented May 25, 2020 • edited

coveralls commented May 25, 2020 • edited

remarkablemark commented May 25, 2020

remarkablemark commented May 25, 2020 •

edited

coveralls commented May 25, 2020 •

edited