Update sandboxes to use vite and typescript #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
ChristianMurphy
commented
Aug 9, 2023
| "noUnusedLocals": true, | ||
| "noUnusedParameters": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
| "skipLibCheck": true |
There was a problem hiding this comment.
this should be removed, currently it is blocked by rehypejs/rehype#147
ChristianMurphy
force-pushed
the
migrate-sandboxes-to-vite
branch
from
cadabb6
to
17ed513
Compare
ChristianMurphy
commented
Aug 9, 2023
| "main": "src/main.tsx", | ||
| "type": "module", | ||
| "dependencies": { | ||
| "react": "^18.0.0", |
There was a problem hiding this comment.
this also updates to React 18
ChristianMurphy
commented
Aug 9, 2023
| @@ -48,7 +48,8 @@ | |||
| "sandbox-templates/**/*.tsx" | |||
| ], | |||
| "rules": { | |||
| "@typescript-eslint/naming-convention": "off" | |||
| "@typescript-eslint/naming-convention": "off", | |||
| "react/react-in-jsx-scope": "off" | |||
There was a problem hiding this comment.
the vite react transform does not require react in scope
ChristianMurphy
commented
Aug 9, 2023
Comment on lines
+2
to
+3
| // eslint-disable-next-line n/file-extension-in-import | ||
| import ReactDOM from 'react-dom/client' |
There was a problem hiding this comment.
this lint rule will break the code by adding a .js extension.
react-dom/client is in the export map, react-dom/client.js is not a thing.
the native dependencies in parcel no longer work in browser sandboxes like stackblitz create react app has been (for all intents and purposes) deprecated by the react team vite offers a replacement for both also run sandboxes through typescript to catch potential issues with plugin compatibility and options.
ChristianMurphy
force-pushed
the
migrate-sandboxes-to-vite
branch
from
17ed513
to
de04f8c
Compare
ChristianMurphy
added
📚 area/docs
wooorm
approved these changes
Aug 9, 2023
wooorm
changed the title
This comment has been minimized.
This comment has been minimized.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
the native dependencies in parcel no longer work in browser sandboxes like stackblitz
create react app has been (for all intents and purposes) deprecated by the react team
vite offers a replacement for both
also run sandboxes through typescript to catch potential issues with plugin compatibility and options.
temporary stackblitz links to test with:
https://stackblitz.com/github/ChristianMurphy/.github-remark/tree/migrate-sandboxes-to-vite/sandbox-templates/remark-with-vite
https://stackblitz.com/github/ChristianMurphy/.github-remark/tree/migrate-sandboxes-to-vite/sandbox-templates/remark-rehype-with-vite
https://stackblitz.com/github/ChristianMurphy/.github-remark/tree/migrate-sandboxes-to-vite/sandbox-templates/react-markdown-with-vite
CodeSandbox currently has issues with any repo with a
.in it's name getting blocked by cloudflare or triggering a not authorized error.