Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support MathJax #40

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Add support MathJax #40

merged 1 commit into from
Apr 20, 2020

Conversation

tani
Copy link
Contributor

@tani tani commented Apr 16, 2020

Hi there,

Thank you for great plugin! As I want to use MathJaX instead of KaTeX in this plugin, I create this request. This plugin insert SVG and its stylesheet to each nodes, that SVG is generated by MathJax v3.

Cheers!

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for working on this!

A couple questions though:

packages/rehype-mathjax/readme.md Outdated Show resolved Hide resolved
packages/rehype-mathjax/test.js Outdated Show resolved Hide resolved
packages/rehype-mathjax/renderer.js Outdated Show resolved Hide resolved
packages/rehype-mathjax/renderer.js Outdated Show resolved Hide resolved
packages/rehype-mathjax/renderer.js Outdated Show resolved Hide resolved
@codecov-io

This comment has been minimized.

@tani

This comment has been minimized.

@ChristianMurphy ChristianMurphy requested review from a team April 17, 2020 03:17
@tani tani requested review from wooorm and removed request for a team April 18, 2020 08:02
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think this is ready, only one more tip to not add CSS if it’s unneeded.

packages/rehype-mathjax/index.js Show resolved Hide resolved
packages/rehype-mathjax/index.js Outdated Show resolved Hide resolved
packages/rehype-mathjax/index.js Outdated Show resolved Hide resolved
@tani
Copy link
Contributor Author

tani commented Apr 19, 2020

Thank you for nice comments. I added them.

@wooorm
Copy link
Member

wooorm commented Apr 19, 2020

Btw seems like you haven’t set up GitHub to connect itself to Git: https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address, so unless you do that your contribution won’t be assigned to you.

@wooorm
Copy link
Member

wooorm commented Apr 19, 2020

If you don’t mind, let me know and I’ll merge right away, otherwise, let me know when you set that up and then I’ll merge!

@tani
Copy link
Contributor Author

tani commented Apr 19, 2020

Thanks again for informing me. I fix this in a day and send message you.

@tani
Copy link
Contributor Author

tani commented Apr 19, 2020

I combined all commits into one, and updated email address.

Because I like this project and ecosystem, I keep to contribute this package. Could you add me as collaborator to this repository. I can follow the latest version of MathJax and other vulnerabilities.

I'm planning to use this package to write academic document, and I want to use latest feature of MathJax in my project.

@wooorm wooorm merged commit 4de7685 into remarkjs:master Apr 20, 2020
@wooorm
Copy link
Member

wooorm commented Apr 20, 2020

Thanks for all your work! I can’t publish yet: Ir1d/rehype-mathjax#1.
I also have two further ideas for improvement: #41 and #42.


Because I like this project and ecosystem, I keep to contribute this package. Could you add me as collaborator to this repository. I can follow the latest version of MathJax and other vulnerabilities.

Awesome! We’d be grateful for your help!

We do have policies in place regarding membership, described here: https://github.com/unifiedjs/collective/blob/master/members.md. As we’ve just met, and we can work together already without extra GitHub rights, I think we should first do that for a while!
People first participate for a bit, and based on that, they‘re nominated to become a contributor/member.

Does that make sense? Please do let me know if you have questions about this policy.

@tani
Copy link
Contributor Author

tani commented Apr 20, 2020

I got it. I wait to solve the duplication of package name.

We do have policies in place regarding membership, described here: https://github.com/unifiedjs/collective/blob/master/members.md. As we’ve just met, and we can work together already without extra GitHub rights, I think we should first do that for a while!
People first participate for a bit, and based on that, they‘re nominated to become a contributor/member.

I agreed. I'm so moved by that members policy, which is a ideal style for open source community.
I'll make efforts for credence of your community.

@tani
Copy link
Contributor Author

tani commented Apr 20, 2020

Thanks for all your work! I can’t publish yet: Ir1d/rehype-mathjax#1.

Should we make scope in npm? unifiedjs/ideas#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants