-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for fenced code block info string #345
Conversation
Build failed for some reason, I restarted it and now it’s green again! |
¯_(ツ)_/¯ |
Now lang is the first word of the info instead of been the whole string. As proposed in the issue #342.
@arobase-che Could you update the code here to match syntax-tree/mdast#22? |
Humm, it's already done. See that comment. I updated both the same day (night ...). |
@arobase-che Sorry, missed it! Soooo, I was in the process of merging this, but hmm, from what I read in the commonmark spec they call the whole thing the info string (I still like info instead of info string). However, as we’re removing the lang from it, I’m not sure
/CC @Hypercubed |
This comment has been minimized.
This comment has been minimized.
Would love to see this get merged as we're getting requests for support in downstream projects (gatsby-mdx and mdx). Is there anything I can do to help move this along? It looks like it might just need final review. |
Oups ! Normaly after that, it will be merged soon. @wooorm is about to publish a new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @arobase-che! 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this looks great! I refactored the code a bit so as to not use .trim()
(which removed javascript white-space, which is not the same as markdown white-space). This unearthed that we needed some more fixtures (e.g., for multiple white-space, or for tabs), which I added.
This looks great, thanks @arobase-che!
Landed! |
Hi \o
The discussion is on the corresponding issue #342
Spoiler: It's about info string ;)
💘