Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CommonMark] Leading/trailing newlines are stripped in the value of fenced codeblock #351

Closed
ikatyang opened this issue Aug 31, 2018 · 2 comments · Fixed by #423
Closed

[CommonMark] Leading/trailing newlines are stripped in the value of fenced codeblock #351

ikatyang opened this issue Aug 31, 2018 · 2 comments · Fixed by #423
Labels
remark-parse 🐛 type/bug This is a problem

Comments

@ikatyang
Copy link
Contributor

Subject of the issue

commonmark: true

```


123


```

Steps to reproduce

astexplorer

Expected behaviour

Same as CommonMark playground:

{
  "type": "code",
  "lang": null,
  "value": "\n\n123\n\n"
}

Actual behaviour

 {
   "type": "code",
   "lang": null,
-  "value": "\n\n123\n\n"
+  "value": "123"
 }

Original post: prettier/prettier#5037
@ikatyang ikatyang mentioned this issue Aug 31, 2018
Merged
2 tasks
@alexander-akait
Copy link

/cc @wooorm looks we have a lot of bugs, maybe we can release version with fixes?

@wooorm
Copy link
Member

wooorm commented Aug 31, 2018

@evilebottnawi Definitely! But we should also get a release out the door 🚪🛳

I’m hoping to get GH-345, GH-346, and potentially GH-321 in there though!

@wooorm wooorm added 🐛 type/bug This is a problem help wanted 🙏 This could use your insight or help remark-parse needs pr labels Oct 14, 2018
wooorm added a commit that referenced this issue Jul 15, 2019
@wooorm
Fix initial, final newlines in fenced code
8d8582c 
Closes GH-351.
@wooorm wooorm mentioned this issue Jul 15, 2019
Merged
@wooorm wooorm added has pr and removed needs pr labels Jul 15, 2019
wooorm added a commit that referenced this issue Jul 15, 2019
@wooorm
Fix initial, final newlines in fenced code
f89fd77 
Closes GH-351.
Closes GH-423.

Reviewed-by: Marouane Fazouane <fazouanem3@gmail.com>
Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Oct 31, 2019
@brettz9
- Testing: Get plugins tests to work with eslint 6
cce4312 
- Teting: Expect an extra line break since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
- Linting: Remove call to lint absent `Makefile.js`
- Linting: Add ignore file and explicitly exclude undesired
- npm: Update object-assign, unified, remark-parse deps.
- npm: Update eslint-release, chai, mocha, eslint devDeps
- npm: Change from deprecated istanbul to nyc
- npm: Add ignore file
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Oct 31, 2019
@brettz9
- Fix: Apply base indent to multiple line breaks; amend test to check
6e700b7 
- Testing: Get plugins tests to work with eslint 6
- Teting: Expect an extra line break since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
- Linting: Remove call to lint absent `Makefile.js`
- Linting: Add ignore file and explicitly exclude undesired
- npm: Update object-assign, unified, remark-parse deps.
- npm: Update eslint-release, chai, mocha, eslint devDeps
- npm: Change from deprecated istanbul to nyc
- npm: Add ignore file
@brettz9 brettz9 mentioned this issue Oct 31, 2019
Closed
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Oct 31, 2019
@brettz9
Upgrade: Update deps. and devDeps; istanbul -> nyc
9a65621 
Update object-assign, unified, remark-parse for deps and eslint-release, chai, mocha, eslint for devDeps.
In process of updating:

1. Get plugins tests to work with eslint 6
2. In whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Oct 31, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
6fd8934 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps. and devDeps; istanbul -> nyc

Update object-assign, unified, remark-parse for deps and eslint-release, chai, mocha, eslint for devDeps.
In process of updating:

1. Get plugins tests to work with eslint 6
2. In whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Nov 1, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
be727b4 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps. and devDeps; istanbul -> nyc

Update object-assign, unified, remark-parse for deps and eslint-release, chai, mocha, eslint for devDeps.
In process of updating:

1. Get plugins tests to work with eslint 6
2. In whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Nov 1, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
39473a5 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps. and devDeps; istanbul -> nyc

Update object-assign, unified, remark-parse for deps and eslint-release, chai, mocha, eslint for devDeps.
In process of updating:

1. Get plugins tests to work with eslint 6
2. In whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Nov 1, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
697b0ac 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps.

Update object-assign, unified, remark-parse for deps. In process of updating,
for whitespace processor test, add an extra line break
for the expected since `remark-parse@7` started preserving them
(see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Nov 1, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
f3ba044 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps.

Update object-assign, unified, remark-parse for deps. In process of updating,
for whitespace processor test, add an extra line break
for the expected since `remark-parse@7` started preserving them
(see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Nov 1, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
bb4bfe6 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps.

Update object-assign, unified, remark-parse for deps. In process of updating,
for whitespace processor test, add an extra line break
for the expected since `remark-parse@7` started preserving them
(see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Nov 1, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
7b19951 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps.

Update object-assign, unified, remark-parse for deps. In process of updating,
for whitespace processor test, add an extra line break
for the expected since `remark-parse@7` started preserving them
(see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Nov 1, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
b88d526 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps.

Update unified, remark-parse for deps. In process of updating,
for whitespace processor test, add an extra line break
for the expected since `remark-parse@7` started preserving them
(see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Nov 2, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
b1e4c3f 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps.

Update unified, remark-parse for deps. In process of updating,
for whitespace processor test, add an extra line break
for the expected since `remark-parse@7` started preserving them
(see remarkjs/remark#351 )
brettz9 added a commit to brettz9/eslint-plugin-markdown that referenced this issue Nov 3, 2019
@brettz9
IGNORE until new eslint processor API used eslint#126 (comment) / htt…
3d30530 
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552

Upgrade: Update deps.

Update unified, remark-parse for deps. In process of updating,
for whitespace processor test, add an extra line break
for the expected since `remark-parse@7` started preserving them
(see remarkjs/remark#351 )
@wooorm wooorm removed the help wanted 🙏 This could use your insight or help label Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
remark-parse 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix initial, final newlines in fenced code remarkjs/remark
3 participants
@wooorm @alexander-akait @ikatyang