Fix inline code and vertical bars in tables #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooorm
changed the title
|
/cc @ikatyang What do you think?
|
|
Since GFM is widely adopted, matching GFM should be better I think. And of course it's even better if it could be fixed on the GFM side. |
Murderlon
approved these changes
Jul 19, 2019
wooorm
changed the title
Previously, inline code got preference over the table cell itself. This was added due to GH-73 in GH-83 four years ago. That behaviour does not match current GFM and lead to unexpected results in GH-295, GH-320, and GH-396. **This PR fixes them, but introduces a conundrum: GFM does not allow empty inline code in cells. Which is weird. Should we support that (why not? 🤷) or match GFM?** Related to GH-73. Related to GH-83. Closes GH-295. Closes GH-320. Closes GH-396.
* Remove support for empty inline code * Only trim inline code content by one character on both sides, if both the initial and final character are a space or a line feed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes inline code in table cells. Previously. Inline code got preference over the table cell itself. This was added due to GH-73 in GH-83 four years ago.
That behaviour does not match current GFM and let to unexpected results in GH-295, GH-320, and GH-396.
Additionally, inline code cannot be empty in CM/GFM.
Related to GH-73.
Related to GH-83.
Closes GH-295.
Closes GH-320.
Closes GH-396.