Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the table contains inline-coded |, it will be broken #165

Closed
Yarakashi-Kikohshi opened this issue Dec 26, 2021 · 6 comments
Closed

If the table contains inline-coded |, it will be broken #165

Yarakashi-Kikohshi opened this issue Dec 26, 2021 · 6 comments
Labels

Comments

@Yarakashi-Kikohshi
Copy link

If the table contains inline-coded |, it will be broken

When creating table containing inline-coded vertical bar, the table is broken.

demo

|                contents                | description       |
| :------------------------------------: | :---------------- |
| If the table contains inline-coded `|` | it will be broken |

Result of displaying

tabel-in-inlineCoeded-verticalBar

This problem occurs in both Remark and Marked compilers.
Of course, this problem doesn't seem to depend on the CSS theme.

Version info.

Microsoft Edge 96.0.1054.62 (64bit)
Markdown Viewer 4.0

Thank you for the very easy-to-use extension!

@simov
Copy link
Owner

simov commented Dec 26, 2021

Yes, that seems to be a compiler issue.

@simov simov added the compiler label Dec 26, 2021
@Yarakashi-Kikohshi
Copy link
Author

Should this issue be raised by remark.js or marked.js?
If so, I will close this issue.

@simov
Copy link
Owner

simov commented Dec 26, 2021

Yes, it is part of what the compiler/parser does. They may have a fix for it already, in that case I will have to update the version used here.

@Yarakashi-Kikohshi
Copy link
Author

Thank you for your prompt reply!!:smile:

And, I checked the issue of each repository.
Similar issues were discussed in each compiler's repository, but I couldn't find the conclusion I expected.

I'm going to put up with it until the problem is resolved.:persevere:

Current status regarding this issue

marked.js

In marked.js, it seems to be stuck due to regex problems.

cf. The vertical bars within backsticks shouldn't be interpreted as table cell delimiter. · Issue #1375 · markedjs/marked

remark.js

In remark.js, inline-coded | is interpreted as a table, which is the same behavior as GFM, so it does not seem to correspond at present.

cf. Fix inline code and vertical bars in tables by wooorm · Pull Request #420 · remarkjs/remark

@wooorm
Copy link

wooorm commented Jan 6, 2022

The displayed result matches how GH does it btw, try pasting it here:

contents description
If the table contains inline-coded ` `

@Yarakashi-Kikohshi
Copy link
Author

@wooorm
Yes. I found out by looking at issue # 420 of remark.js.

I think it's important to look similar to GH, but I don't want `|` to be considered part of the table.
It seems that mark.js will support the notation I am expecting, so I wait until then...:persevere:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants