-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language for .remarkrc
, .remarkignore
to VSC
#78
Conversation
This comment has been minimized.
This comment has been minimized.
"languages": [ | ||
{ | ||
"id": "ignore", | ||
"extensions": [ | ||
".remarkignore" | ||
] | ||
}, | ||
{ | ||
"id": "json", | ||
"filenames": [ | ||
".remarkrc" | ||
] | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is new-ish to me.
Does this only impact people cloning this repo?
Or does this somehow tell vscode how to highlight these files if remark
is installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the plugin manifest, not local development settings.
Or does this somehow tell vscode how to highlight these files if remark is installed?
☝️ This exactly
I basically copied it from https://github.com/microsoft/vscode-eslint/blob/main/package.json#L490-L503
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interpreting the :+1:
by Christian as an ✅ review
.remarkrc
, .remarkignore
to VSC
Initial checklist
Description of changes
These languages can’t be detected by VSCode by default.