Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language for .remarkrc, .remarkignore to VSC #78

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Add language for .remarkrc, .remarkignore to VSC #78

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5017317
Define languages for .remarkrc and .remarkignore
remcohaszing Dec 22, 2021
6e97c72
Merge branch 'main' into define-config-languages
wooorm Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,21 @@
}
}
}
}
},
"languages": [
{
"id": "ignore",
"extensions": [
".remarkignore"
]
},
{
"id": "json",
"filenames": [
".remarkrc"
]
}
]
Comment on lines +220 to +233
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new-ish to me.
Does this only impact people cloning this repo?
Or does this somehow tell vscode how to highlight these files if remark is installed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the plugin manifest, not local development settings.

Or does this somehow tell vscode how to highlight these files if remark is installed?

☝️ This exactly

I basically copied it from https://github.com/microsoft/vscode-eslint/blob/main/package.json#L490-L503

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interpreting the :+1: by Christian as an ✅ review

},
"devDependencies": {
"@istanbuljs/nyc-config-typescript": "^1.0.1",
Expand Down