Increase stack operation timeout #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejholmes
force-pushed
the
stack-op-timeout
branch
from
b8211e2
to
fdddce8
Compare
phobologic
reviewed
Dec 14, 2016
phobologic
approved these changes
Dec 14, 2016
|
It's a pretty low level detail. We could make it configurable, but I doubt anyone would ever configure it. We can probably address that if it comes up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10 minutes is a little too aggressive, since CloudFormation gets slow sometimes. 1 hour is a little more reasonable, this just prevents Empire from getting in a stuck state and holding onto the stack operation lock indefinitely.