Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scaling process to negative values to remove resources #1064

Merged
merged 2 commits into from
Mar 28, 2017
Merged

Allow scaling process to negative values to remove resources #1064

merged 2 commits into from
Mar 28, 2017

Conversation

ejholmes
Copy link
Contributor

Closes #1042

There's two changes here:

  1. Allow processes to be scaled to a negative value, to remove the AWS resources.
  2. Removes the condition where resources for scheduled jobs wouldn't be added to the template if the scale was 0. Now they're added, but the CloudWatch Events trigger is disabled if the process is scaled down.

phobologic
phobologic approved these changes Mar 25, 2017
View reviewed changes
cmd/emp/scale.go Outdated
}
qty = &v
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this blank else block isn't necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, no idea why I added this block. I'll remove it. Not necessary.

@ejholmes ejholmes merged commit 2f51089 into master Mar 28, 2017
@ejholmes ejholmes deleted the negative-scale branch March 28, 2017 03:34
@ejholmes ejholmes mentioned this pull request Sep 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phobologic phobologic phobologic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ejholmes @phobologic