Configurable instance port pool #1096
Conversation
migrations.go
Outdated
| type Schema struct { | ||
| // For legacy ELB's (not ALB) Empire manages a pool of host ports to | ||
| // ensure that all applications have a unique port on the EC2 instance. | ||
| // This option specifies the beginning of that range. |
There was a problem hiding this comment.
Good catch. Updated.
| const table = `CREATE TABLE ports ( | ||
| id uuid NOT NULL DEFAULT uuid_generate_v4() primary key, | ||
| port integer, | ||
| app_id uuid references apps(id) ON DELETE SET NULL |
There was a problem hiding this comment.
should it also map to a process as well?
There was a problem hiding this comment.
This actually gets updated in a later migration: https://github.com/remind101/empire/blob/master/migrations.go#L250-L251
There was a problem hiding this comment.
Ahhh, ok - makes sense.
|
|
||
| func (s *Schema) migrations() []migrate.Migration { | ||
| ports := migrate.Migration{ | ||
| ID: 4, |
There was a problem hiding this comment.
Is this changing an older migration? Is that going to cause any issues?
There was a problem hiding this comment.
It's explained in the PR description, but, for existing installations of Empire, this doesn't change anything. For new installations of Empire, you can set these options to pre-configure the pool when the migration runs.
| db.Schema = &empire.Schema{ | ||
| InstancePortPool: &empire.InstancePortPool{ | ||
| Start: uint(c.Int(FlagInstancePortPoolStart)), | ||
| End: uint(c.Int(FlagInstancePortPoolEnd)), |
There was a problem hiding this comment.
Is this where we'd catch it if one of the two vars isn't defined? Might be useful to have some helpful warning/error messages in that case.
There was a problem hiding this comment.
In any case where you provided invalid values here, the migration would fail, and you'd see an error in logs.
ejholmes
force-pushed
the
configurable-instance-ports
branch
2 times, most recently
from
860d54a
to
2dc38c4
Compare
This commit adds new flags for configuring the instance port pool that Empire uses to allocate instance ports to applications and processes.
ejholmes
force-pushed
the
configurable-instance-ports
branch
from
be0237c
to
791f978
Compare
This adds options for configuring the range of EC2 instance ports that Empire manages and allocates to applications that use legacy ELB's to prevent port conflicts.
This makes it easier to run multiple Empire daemons that schedule work into a single ECS cluster. Each Empire daemon can now specify it's own range of instance ports to allocate from to prevent overlap.
Note that, once configured, changing the flags will have no effect, so this only applies to new installations of Empire. Previous installations will continue to use the 9000-10000 range.