Don't wait for container to stop if the client disconnects. #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
ejholmes
added a commit
that referenced
this pull request
Jul 16, 2015
Don't wait for container to stop if the client disconnects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #587. Turns out, a lot of what I was doing previously is unnecessary.
AttachToContainerwill block while theRead'ing from the connection doesn't return io.EOF, so there's no need toWaitContainer. At that point in time, the container is already stopped because it exited, so there's no need to stop the container and we can just remove it.If the user
killall emp's then the container will still be removed because the connection closes and returns io.EOF.