Remove existing SSL management. #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,12 +57,6 @@ func New(e *empire.Empire, authenticator auth.Authenticator) httpx.Handler { | |||
| // OAuth | |||
| r.Handle("/oauth/authorizations", &PostAuthorizations{e}).Methods("POST") | |||
|
|
|||
| // SSL | |||
There was a problem hiding this comment.
We should map these to http handlers that explain that they were removed.
|
This looks good so far - are you planning to put the new SSL attachment stuff in this same PR before merging? |
|
Yep, I'll be adding the new endpoint shortly with support in |
| return err | ||
| } | ||
|
|
||
| if err := s.releaser.ReleaseApp(ctx, app); err != nil { |
There was a problem hiding this comment.
Instead of re-releasing, this should probably creat a new release.
There was a problem hiding this comment.
I'll follow up with this in a separate PR that makes the API simpler for creating new releases for apps.
ejholmes
added a commit
that referenced
this pull request
Dec 18, 2015
Remove existing SSL management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #471
Fixes #662
This still needs client support (
emp certs-attach) and associated API endpoint, but this would change how certs are managed via Empire, in that you don't use Empire to manage certs, just attach existing certs to apps.Note that #700 will still be required to fix the fact that ELB's can't be updated to use new certs.
The basic flow for attaching a cert to an Empire application will be:
I think this will also ultimately work better when we add more backends, since we won't have to try to support varying CertManager implementations.
Also note that this will be backwards compatible with existing certificates inside Empire (see migration).
TODO