Expose errors in Tugboat properly #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejholmes
force-pushed
the
trace-after
branch
from
ecf9f96
to
5d9dd0b
Compare
ejholmes
force-pushed
the
trace-after
branch
from
54d0e44
to
05999f4
Compare
ejholmes
changed the title
ejholmes
changed the title
|
|
||
| // DecodeJSONMessageStream wraps an io.Writer to decode a jsonmessage stream into | ||
| // plain text. Bytes written to w represent the decoded plain text stream. | ||
| func DecodeJSONMessageStream(w io.Writer) *DecodedJSONMessageWriter { |
There was a problem hiding this comment.
Also refactored out how the jsonmessage stream is decoded, so you can just wrap an io.Writer to decode the stream and write plain text.
|
👍 |
ejholmes
added a commit
that referenced
this pull request
Jan 5, 2016
Expose errors in Tugboat properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "fixes" https://app.honeybadger.io/projects/43058/faults/14165058 in that it makes the error visible. Previously, it would get silenced and people would be confused why they're deployment failed (tag wasn't found in the docker registry. See #644). It's the biggest source of errors that we see from Empire, so it's annoying when you just see a blank error.
The behavior before was to write the error to the log stream, then update the deployment status in Tugboat as failed. But if there was an error writing to the log stream, then the error would just be silenced. It's better if we just update the deployment status in Tugboat passing it the actual error that happened.
Depends on remind101/tugboat#41
TODO