Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate parsed accessed tokens. #780

Merged
merged 2 commits into from
Apr 12, 2016
Merged

Validate parsed accessed tokens. #780

merged 2 commits into from
Apr 12, 2016

Conversation

ejholmes
Copy link
Contributor

I've seen cases where Claims["User"]["Name"] is an empty string. I don't have a good repro for when that can happen (last time I saw it, I had signed in when the GitHub API was having issues), but this will validate the access token before creating it and after decoding it.

@phobologic
Copy link
Contributor

👍

@ejholmes ejholmes merged commit 549c08e into master Apr 12, 2016
@ejholmes ejholmes deleted the empty-user-name branch April 12, 2016 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants