Only destroy load balancers when the app is destroyed. #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
| @@ -527,16 +527,18 @@ func (m *Scheduler) loadBalancer(ctx context.Context, app *scheduler.App, p *sch | |||
| return l, nil | |||
| } | |||
|
|
|||
| func (m *Scheduler) removeLoadBalancer(ctx context.Context, app string, p string) error { | |||
| l, err := m.findLoadBalancer(ctx, app, p) | |||
| func (m *Scheduler) removeLoadBalancers(ctx context.Context, app string) error { | |||
There was a problem hiding this comment.
Was this called somewhere else before? I'm not sure how this stops the previous behavior - only that it adds the behavior that it will now make sure that the LBs are destroyed when Remove is called?
There was a problem hiding this comment.
So, Remove is called when the entire app is destroyed. Previously, this was in RemoveProcess, which is called to remove an individual process in the app (say for example, you had a worker1 process, but then you changed its name to worker, we remove the irrelevant ecs service).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #798
I think it's a lot safer if we only ever destroy a load balancer when the entire app is destroyed, rather than per process. With the existing behavior, it would be possible to deploy a Procfile without the
webprocess and the load balancer would be destroyed, making it more difficult to recover from (if you have CNAME's pointed at it).With the new behavior, it does mean that you could potentially accumulate unused load balancers, but those can always be destroyed manually if it's a real problem.