Switch default ECS service resource to Custom::ECSService. #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can probably be safely merged now that #878 was merged, but I'll try doing it manually on a couple apps in production to make sure there's no downtime. UPDATE: Moved a bunch of our prod services over to Custom::ECSService and it's been working well for a while now. |
ejholmes
force-pushed
the
default-custom-dns
branch
from
dbc42e6
to
192aba7
Compare
|
For the record, also moved prod apps to this with 0 downtime |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been working pretty well on the apps that we've enabled it on, and the overall user experience will be better (especially in cases where rollback is necessary).
I think this should be merged before we release 0.11.0, but I don't plan on merging this until we've manually switched our applications over to Custom::ECSService, since it potentially incurs some downtime when the old ECS services are destroyed.