Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle creation failures of custom resources #938

Merged
merged 3 commits into from
Jul 18, 2016

Conversation

ejholmes
Copy link
Contributor

@ejholmes ejholmes commented Jul 16, 2016

Fixes #918

See #918 for an explanation of what was causing the issue.

This does a few things:

  1. Fixes the issue in Custom CloudFormation resources should gracefully handle stack creation rollbacks #918
  2. Pulls out some of the custom resources framework in server/cloudformation, to pkg/cloudformation/customresources.

End result is that, if creating a new resource fails, the correct error will appear in the CloudFormation events, and request to delete it during the rollback will succeed.

@phobologic
Copy link
Contributor

👍

@ejholmes ejholmes merged commit 60592b5 into master Jul 18, 2016
@ejholmes ejholmes deleted the customresources-bugs branch July 18, 2016 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants