Metrics #953
Merged
Metrics #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be cool if we had an |
|
Good call, I can add that to the embedded error reporter 👍 |
| return stats.Null, nil | ||
| } | ||
|
|
||
| func newDataDogStats(addr string) (stats.Stats, error) { |
There was a problem hiding this comment.
It might be worth at least having a datadog & plain statsd implementation at first. I think the only difference would be removing tags?
There was a problem hiding this comment.
Cool, yeah, I can add a plain statsd backend as well.
| tags = append(tags, fmt.Sprintf("error:%s", err.Code())) | ||
| stats.Inc(fmt.Sprintf("aws.request.error"), 1, 1.0, tags) | ||
| stats.Inc(fmt.Sprintf("aws.request.%s.error", r.ClientInfo.ServiceName), 1, 1.0, tags) | ||
| stats.Inc(fmt.Sprintf("aws.request.%s.%s.error", r.ClientInfo.ServiceName, r.Operation.Name), 1, 1.0, tags) |
There was a problem hiding this comment.
nm on the error stat :) sorry for jumping the gun
|
So awesome 👍 |
|
Added a commit that adds a statsd backend as well, and also changed the flag to empire server --stats=statsd://localhost:8125Or empire server --stats=dogstatsd://localhost:8126Or EMPIRE_STATS=statsd://localhost:8125 empire server |
|
Also added some sample of the go runtime metrics every 30 seconds as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up a small stats framework, and adds some middleware to all AWS clients that will increment some counters for aws requests and responses. This will allow us to get better visibility into throttling, or other issues.
We can also start using the
stats.*methods to generate metrics for the other things, like number of deploys, how long deploys take, etc.The stats package is just a small layer of abstraction over a statsd'ish client, and I've only provided a datadog implementation for now.
Metrics we should have
aws.request.*For outbound AWS requestsheroku.request.*For inbound Heroku API requests.runtime.*Golang runtime stats.heroku.auth.errorfor authorization errors.core.*for core API calls.scheduler.cloudformation.template_sizeFor tracking generated template sizes