Publish RunEvent on command start and finish #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I wonder if Can you update the CHANGELOG as well? Otherwise, 👍 |
| @@ -15,6 +15,7 @@ | |||
| * The database schema version is now checked at boot, as well as in the http health checks. [#893](https://github.com/remind101/empire/pull/893) | |||
| * The log level within empire can now be configured when starting the service. [#929](https://github.com/remind101/empire/issues/929) | |||
| * The CloudFormation backend now has experimental support for a `Custom::ECSTaskDefinition` resource that greatly reduces the size of generated templates. [#935](https://github.com/remind101/empire/pull/935) | |||
| * `emp run` now publishes an event when it is ran | |||
There was a problem hiding this comment.
By convention, we also include a link to the PR that introduced the change (this one).
There was a problem hiding this comment.
Thanks, I amended the last commit.
Nosajool
force-pushed
the
emp-run-send-start-event
branch
from
ad45c4f
to
9e19ad8
Compare
Change start action from "started" to "started running"
Nosajool
force-pushed
the
emp-run-send-start-event
branch
from
9e19ad8
to
d26ce03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #943
Publishes 2 events: