Switch to Application Load Balancers #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - really should have the ability to switch between old ELB and new ALB at least, just in case there are unforeseen issues with the new system. |
|
Alright. By default, classic ELB's will be used, but you can now (experimentally) switch to the new application load balancers by setting Updated the changelog as well. |
|
Awesome. 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #968
This is mostly a POC at this point, since I haven't done any work to support both classic ELB's and new ALB's so that you can easily swap between both in case there are issues.
But, this does seem to work. The advantage of using ALB's is primarily that we no longer need to allocate and manage instance ports, which means multiple "web" procs can run on the same EC2 instance.
The first commit just updates the aws-sdk-go dependency, and the second includes the actual changes that switch to ALB's.