Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix rendering order of Styling docs #1680

Merged
merged 1 commit into from Jun 9, 2022
Merged

docs: fix rendering order of Styling docs #1680

merged 1 commit into from Jun 9, 2022

Conversation

DoK6n
Copy link
Contributor

@DoK6n DoK6n commented Jun 2, 2022

Description

In the Core concepts > Styling tab of the official document, if you apply the example of emotion and styled-component, styling will not be applied.
You need to change the order of ThemeProvider and AllStyledComponent for it to take effect. So I've edited this part of the documentation.

Also, in emotion and styled-component, @remirror/styles was raised to the top because the phrase that install is required is at the end of the document, so you may not be able to find it.

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

Screenshots

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022

⚠️ No Changeset found

Latest commit: a51aa23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@ronnyroeller ronnyroeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronnyroeller ronnyroeller enabled auto-merge (squash) June 9, 2022 14:58
@ronnyroeller ronnyroeller merged commit c7f5013 into remirror:main Jun 9, 2022
@ronnyroeller
Copy link
Collaborator

Thanks a lot for your contribution, @DoK6n !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants