Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jsdom polyfilling #731

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix jsdom polyfilling #731

merged 1 commit into from
Sep 29, 2020

Conversation

ifiokjr
Copy link
Member

@ifiokjr ifiokjr commented Sep 29, 2020

Description

Fix support for jest-remirror with versions before the 16 release.

Deprecate jsdomExtras which has been replaced by jsdomPolyfill.

Bump dependencies with minor and patch updates.

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

@ifiokjr
Fix jsdom polyfilling
cdeae50 
Also upgrade dependencies and bump so minor and patch version updates.
@ifiokjr ifiokjr added the type: fix 🔧 A pull request that fixes a known bug. label Sep 29, 2020
@ifiokjr ifiokjr self-assigned this Sep 29, 2020
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2020

🦋 Changeset detected

Latest commit: cdeae50

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added framework: react ⚛️ Any changes to packages which are exclusively used for react code bases. package: @remirror/cli 📟 A label for the remirror cli. package: jest-prosemirror 🎭 A change has occured in the jest-prosemirror package. package: jest-remirror 🃏 Label for the jest-remirror package package: prosemirror-suggest 💡 A change has occurred in prosemirror-suggest. type: changeset 🦋 A change has been made to the changesets folder. type: support 📚 A change focused on improving the architecture and structure of the support directory. labels Sep 29, 2020
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f7310baa7effe758e1aabf9--remirror.netlify.app

@ifiokjr ifiokjr merged commit bcf3b2c into next Sep 29, 2020
@ifiokjr ifiokjr deleted the jest-remirror-jsdom-support branch September 29, 2020 10:50
@github-actions github-actions bot mentioned this pull request Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ifiokjr ifiokjr

Labels
framework: react ⚛️ Any changes to packages which are exclusively used for react code bases. package: jest-prosemirror 🎭 A change has occured in the jest-prosemirror package. package: jest-remirror 🃏 Label for the jest-remirror package package: prosemirror-suggest 💡 A change has occurred in prosemirror-suggest. package: @remirror/cli 📟 A label for the remirror cli. type: changeset 🦋 A change has been made to the changesets folder. type: fix 🔧 A pull request that fixes a known bug. type: support 📚 A change focused on improving the architecture and structure of the support directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ifiokjr