Handle falsy errors correctly

remix-run · Feb 14, 2024 · 3ba3024 · 3ba3024
1 parent a8bedaa
commit 3ba3024
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/react-router/lib/hooks.tsx b/packages/react-router/lib/hooks.tsx
@@ -697,7 +697,7 @@ export function _renderMatches(
   let errors = dataRouterState?.errors;
   if (errors != null) {
     let errorIndex = renderedMatches.findIndex(
-      (m) => m.route.id && errors?.[m.route.id]
+      (m) => m.route.id && errors?.[m.route.id] !== undefined
     );
     invariant(
       errorIndex >= 0,

diff --git a/packages/router/router.ts b/packages/router/router.ts
@@ -8,7 +8,6 @@ import {
   warning,
 } from "./history";
 import type {
-  ActionFunction,
   AgnosticDataRouteMatch,
   AgnosticDataRouteObject,
   DataStrategyMatch,
@@ -25,7 +24,6 @@ import type {
   HTMLFormMethod,
   HandlerResult,
   ImmutableRouteKey,
-  LoaderFunction,
   MapRoutePropertiesFunction,
   MutationFormMethod,
   RedirectResult,
@@ -4214,7 +4212,7 @@ async function callLoaderOrAction(
           }),
           loadLazyRouteModule(match.route, mapRouteProperties, manifest),
         ]);
-        if (handlerError) {
+        if (handlerError !== undefined) {
           throw handlerError;
         }
         result = values[0];