Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dangerouslySetInnerHTML #170

Closed
davejacobs opened this issue Aug 6, 2014 · 3 comments · Fixed by #175
Closed

dangerouslySetInnerHTML #170

davejacobs opened this issue Aug 6, 2014 · 3 comments · Fixed by #175

Comments

@davejacobs
Copy link

I'm trying to dangerouslySetInnerHTML inside of a <Link /> component, but the content isn't showing up inside of the resulting anchor tag. Is there something I can do to make this available to <Link /> components?
@ryanflorence
Copy link
Member

hmm, I don't know enough about dangerouslySetInnerHTML, but can you wrap a dangerous span with link?

<Link to="stuff"><span dangerouslySetInnerHTML={{__html: html}}/></Link>

@davejacobs
Copy link
Author

I can do that, no prob. Just wanted to see if you thought this functionality could make its way into <Link /> itself. No worries if not.

Thanks for a great library!

@ryanflorence
Copy link
Member

Yeah, seems like we should support it.

@brigand brigand mentioned this issue Aug 6, 2014
Merged
ryanflorence added a commit that referenced this issue Aug 7, 2014
@ryanflorence
Merge pull request #175 from brigand/issue-170-dangerouslySetInnerHTML
d63e85b 
Merge props passed to Link #170
jakobz pushed a commit to jakobz/react-router that referenced this issue Aug 7, 2014
@brigand
[added] support for extra props in Links, fixes remix-run#170
a416396
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge props passed to Link #170
2 participants
@davejacobs @ryanflorence