Bad npm package for 2.0.0-rc2

[insin]

The node_modules/history issue is back in the 2.0.0-rc2 npm package:

http://registry.npmjs.org/react-router/-/react-router-2.0.0-rc2.tgz

[patrickheeney]

Is this the issue you are referring to?

ERROR in ./~/react-router/~/history/lib/useQueries.js
Module not found: Error: Cannot resolve module 'query-string' in node_modules/react-router/node_modules/history/lib
 @ ./~/react-router/~/history/lib/useQueries.js 15:19-42

ERROR in ./~/react-router/~/history/lib/createHistory.js
Module not found: Error: Cannot resolve module 'deep-equal' in node_modules/react-router/node_modules/history/lib
 @ ./~/react-router/~/history/lib/createHistory.js 10:17-38

If so, I am experiencing this as well.

[taion]

@ryanflorence What version of npm are you on?

[taion]

Contra the npm3 release notes, it looks like this fix wasn't applied to npm3 because the relevant check got vendored. I backed out my build tooling change: #2789. I guess we'll have to re-release. Sorry.

[mjackson]

If it ain't broke... :P
On Wed, Dec 30, 2015 at 2:37 PM Jimmy Jia notifications@github.com wrote:

Contra the npm3 release notes, it looks like this fix wasn't applied to
npm3 because the relevant check got vendored. I backed out my build tooling
change: #2789 #2789. I guess
we'll have to re-release. Sorry.

—
Reply to this email directly or view it on GitHub
#2785 (comment)
.

[taion]

@mjackson The npm release notes claimed it was fixed. I even checked that it was... just not for npm3, which I don't use. Oops.

The relevant npm issue is npm/npm#10445, for those interested.

[mjackson]

It's ok :) I break stuff all the time. nbd
On Wed, Dec 30, 2015 at 2:56 PM Jimmy Jia notifications@github.com wrote:

@mjackson https://github.com/mjackson The npm release notes claimed it
was fixed. I even checked that it was... just not for npm3, which I don't
use. Oops.

The relevant npm issue is npm/npm#10445
npm/npm#10445, for those interested.

—
Reply to this email directly or view it on GitHub
#2785 (comment)
.

[insin]

2.0.0-rc3 looks good 👍

[ryanflorence]

If you don't ship 4 rc's in one day, then you just aren't shipping enough.

[taion]

We should ship a 5th w/a history v2 dependency as soon as we publish history v2, BTW.

[ryanflorence]

soon as @mjackson ships it, will do.

[mjackson]

i'm on it

On Thu, Dec 31, 2015 at 9:22 AM Ryan Florence notifications@github.com
wrote:

soon as @mjackson https://github.com/mjackson ships it, will do.

—
Reply to this email directly or view it on GitHub
#2785 (comment)
.