Redirections don't trigger rendering

[baskerville]

Please consider the following example:

var React = require("react"),
    Router = require("react-router"),
    Routes = Router.Routes,
    Route = Router.Route,
    DefaultRoute = Router.DefaultRoute;

var ForbiddenRoute = {
    statics: {
        willTransitionTo: function (transition) {
            transition.redirect("/");
        }
    }
};

var Home = React.createClass({
    render: function () {
        return (
            <p>Home</p>
        );
    }
});

var GoHome = React.createClass({
    mixins: [ForbiddenRoute],
    render: function () {
        return null;
    }
});

var App = React.createClass({
    render: function () {
        return (
            <this.props.activeRouteHandler/>
        );
    }
});

var routes =  (
    <Routes location="history">
        <Route path="/" handler={App}>
            <Route path="/gohome" handler={GoHome}/>
            <DefaultRoute handler={Home}/>
        </Route>
    </Routes>
);

React.renderComponent(routes, document.body);

After visiting /gohome I would expect Home to be rendered, but it isn't.

[licx]

I'm experiencing the same issue

[mjackson]

What happens if your statics are defined in GoHome rather than in your ForbiddenRoute mixin?

[vimto]

I'm experiencing this too, with the equivalent of the statics defined in the component rather than in a mixin.

[baskerville]

@mjackson
The result is the same.

[vimto]

FYI, same result when I try and use the <Redirect /> component.

[mjackson]

@baskerville Can you please try this on 0.9.2? We shipped a fix yesterday that should address this problem.

[baskerville]

The issue still holds with 0.9.2.

[dancannon]

I am also experiencing this but only when location="history". Here is the code I use to redirect:

/** @jsx React.DOM */
var React = require('react');
var {Navigation} = require('react-router');

var toolkitApi = require('../toolkit/api');
var authUtils = require('../utils/auth');

module.exports = React.createClass({
    displayName: 'AuthenticatedContainer',

    mixins: [Navigation],

    statics: {
        willTransitionTo: function(transition, params) {
            if (!authUtils.isAuthenticated()) {
                return transition.redirect('login', params, {
                    redirect: transition.path
                });
            }
        }
    },

    onLogout: function() {
        this.transitionTo('/', this.props.params);
    },

    componentWillMount: function() {
        toolkitApi.on('logout', this.onLogout);
    },

    componentWillUnmount: function() {
        toolkitApi.off('logout', this.onLogout);
    },

    render: function() {
        return this.props.activeRouteHandler();
    }
});

[baskerville]

I can confirm that the issue isn't happening when location="hash".

[ryanflorence]

The only time the redirect doesn't render is when the page is initially loaded at the route that redirects. If you navigate to it in an already loaded app it works as expected.

[ryanflorence]

git bisect tells me 47f0599 with all of its awesomeness introduced this. @Gearon, any knee jerk reactions to what might have caused this happen?

[mjackson]

@gaearon ^^^

[gaearon]

Is this unrelated to #336?

[gaearon]

I may be misreading the issue but at a glance it looks exactly like #336 which was introduced a bit earlier than my PR, in c96e34d.

However, you said it was fixed in 0.8.0. Could something from 0.9.x break it again?

[roycehaynes]

Appreciate the contributors to this project! Experiencing exact same issue mentioned here on v0.9.3. What was the resolution?

[roycehaynes]

I just added the fix to node_modules temporarily until this is updated in npm. Thanks guys!

[ryanflorence]

there will be a new release on monday, if not sooner.