Bug: react-router-redux ignores custom getUserConfirmation

[bummzack]

Version

react-router: 4.1.1
react-router-redux: 5.0.0-alpha.6

Test Case

https://codepen.io/anon/pen/gRXzMg

With the above test-case, navigate to "Prompt", enter something into the input-field and then navigate to "Home". The confirm dialog should read "THIS IS A CUSTOM MESSAGE", but it doesn't.

Steps to reproduce

Set the getUserConfirmation on the ConnectedRouter to be something different than the default behavior.
Trigger a confirmation via Prompt component, instead of the custom getUserConfirmation function, the default implementation will always be called.

Expected Behavior

The ConnectedRouter should also use the custom getUserConfirmation instead of the default implementation.

Actual Behavior

The default implementation (eg. using window.confirm) is used, even when getUserConfirmation is set.

[timdorr]

getUserConfirmation is actually a history API. We just pass through to the history creation function. Since you're making your own history instance, you can just pass it in to that: https://github.com/ReactTraining/history#customizing-the-confirm-dialog

[bummzack]

Oh, I wasn't aware of that. Thanks for the heads-up!

[amanmehta25]

@bummzack did this custom getUserConfirmation work for you?

[bummzack]

@amanmehta25 I found getUserConfirmation to be lacking. Several people figured out a solution that uses history.block instead. You can find it here, it has even been turned into a package: #4635 (comment)

[amanmehta25]

Thanks a lot, @bummzack. That really worked for me.