Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support for mixing BrowserRouter and HashRouter in v6 #8108

Closed
tomekpaszek opened this issue Oct 5, 2021 · 1 comment
Closed

Comments

@tomekpaszek
Copy link

What is the new or updated feature that you are suggesting?

I'm currently mixing both BrowserRouter and HashRouter to achieve links like: :repository/:branch#overview-:id
In v6 when trying to use both router I'm getting You cannot render a <Router> inside another <Router>. You never need more than one. message. Would a scenario where you can use both browser and hash routing be possible in the new version?

Why should this feature be included?

To be able to cover scenario mentioned above

@timdorr
Copy link
Member

timdorr commented Oct 5, 2021

This is fundamentally not possible because there are two different history implementations and instances under the hood. They don't compose together. I'm not sure how you have that working, as the context from one Router is going to be overwritten by the next descendant Router.

@timdorr timdorr closed this as completed Oct 5, 2021
brophdawg11 pushed a commit that referenced this issue Mar 27, 2024
Co-authored-by: Hiroshi Ogawa <hi.ogawa.zz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants