Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to manual publish scripts #10055

Merged
merged 4 commits into from
Feb 7, 2023
Merged

Conversation

brophdawg11
Copy link
Contributor

Updates for experimental releases

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2023

⚠️ No Changeset found

Latest commit: 8bfdc1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines -78 to +76
let tag = semver.prerelease(version) == null ? "latest" : "next";
let tag = version.includes("experimental")
? "experimental"
: semver.prerelease(version) == null
? "latest"
: "pre";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduce an experimental tag and change from next -> pre to match what we're using nowadays

// FIXME: @remix-run/router is versioned differently and is only handled
// for experimental releases here
await ensureBuildVersion("router", version);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In experimentals we can do this for router alongside since they all share a version

@brophdawg11 brophdawg11 merged commit 918b158 into dev Feb 7, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/update-publish-script branch February 7, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants