Stabilize useRevalidator #10707
Merged
Stabilize useRevalidator #10707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b9eed2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Jul 17, 2023
| @@ -909,107 +909,6 @@ describe("createMemoryRouter", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it("reloads data using useRevalidator", async () => { | |||
There was a problem hiding this comment.
Existing tests extracted to `use-revalidator-test.tsx
brophdawg11
commented
Jul 17, 2023
| expect(router.state.errors).toBe(null); | ||
| }); | ||
|
|
||
| it("is stable across location changes", async () => { |
There was a problem hiding this comment.
Net new functionality test
brophdawg11
commented
Jul 17, 2023
Comment on lines
+824
to
+830
| return React.useMemo( | ||
| () => ({ | ||
| revalidate: dataRouterContext.router.revalidate, | ||
| state: state.revalidation, | ||
| }), | ||
| [dataRouterContext.router.revalidate, state.revalidation] | ||
| ); |
There was a problem hiding this comment.
This is the only functional change in this PR
This was referenced Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10706
I also restructured some unit tests in 28d8eed. Began with pulling out
useRevalidatortests from the largerdata-memory-router-testand then that led to moving some utils to standalone files and leveraging them instead of copy/pasting them across test suites.