Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include hash in useFormAction() for unspecified actions #10758

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

brophdawg11
Copy link
Contributor

Do not include the hash in useFormAction(undefined) since it's unavailable on the server and causes a hydration error if included. The original issue this code was added to fix was only referring to the search params not being included, we shouldn't have added the hash then. Users can still get a hash by including it in their action if needed and can manage hydration issues accordingly.

Closes remix-run/remix#6976

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: de78d21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Jacob Ebey <jacob.ebey@live.com>
@brophdawg11 brophdawg11 merged commit fb70fed into dev Aug 2, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/form-action-hash branch August 2, 2023 19:43
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

🤖 Hello there,

We just published version 6.15.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.15.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a React <Form> with a URL hash "#" value causes browser Warning that Prop action did not match
2 participants