Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startViewTransition support #10916

Merged
merged 43 commits into from Oct 11, 2023
Merged

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Oct 4, 2023

This PR adds initial support for document.startViewTransition behind some unstable_ APIs so we can get it out into folks hands and start getting some feedback. Right now it's pretty abstracted and opt-in at the link level. We're hoping that once folks start using it we can figure out what other types of complex use-cases exist that we can't yet handle with these APIs.

There are 2 new APIs

  • unstable_viewTransition flag on Link/NavLink/navigate/submit which enables the usage of document.startViewTransition for that navigation
  • unstable_useViewTransitionState(to) - a hook that tells you if there is an active transition to the indicated location (or from a POP/reverse PUSH navigation)

Please see the changeset and docs for more info.

Live demo: https://github.com/brophdawg11/react-router-records



TODO:

  • Unit tests

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: f3db06f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router-dom Minor
react-router Minor
@remix-run/router Minor
react-router-dom-v5-compat Minor
react-router-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit feebfc0 into dev Oct 11, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/start-view-transition branch October 11, 2023 19:25
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.17.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.17.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Incorporate document.startViewTransition
1 participant