Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with partial hydration combined with route.lazy #11121

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Dec 15, 2023

Closes #11120

Todo:

  • Unit Tests

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: 0556de1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router Patch
@remix-run/router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

if (isInitialLoad) {
// On initial hydration we don't do any shouldRevalidate stuff - we just
// call the unhydrated loaders
return isUnhydratedRoute(state, match.route);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was backwards before - we should check lazy and the lack of a loader first, then look for unhydrated routes

@brophdawg11 brophdawg11 merged commit 0f04d11 into dev Dec 18, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/partial-plus-lazy branch December 18, 2023 16:25
Copy link
Contributor

🤖 Hello there,

We just published version 6.21.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.21.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: v7_partialHydration with lazy routes result in empty route
1 participant