Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playgrounds not installing binaries #11747

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

brophdawg11
Copy link
Contributor

Our playgrounds aren't currently getting the binaries without a specific pnpm install react-router step so added that as an up-front setup command

Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: a24c968

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -6,6 +6,7 @@
"scripts": {
"build": "react-router build",
"dev": "node ./server.js",
"setup": "pnpm i react-router@workspace",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this should be handled for us by pnpm. Is our pnpm workspace messed up or is this a limitation of how we programmatically create playgrounds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure - I agree the binary should be properly installed on pnpm i - and it is in an external reproduciton not using workspace:* symlinks. So I think it's either an issue with our setup, or an issue with pnpm and workspace:* deps?

@pcattori pcattori merged commit 4996fbe into v7 Jun 28, 2024
5 checks passed
@pcattori pcattori deleted the brophdawg11/fix-playground branch June 28, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants