-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch back to a caret range for history #2702
Conversation
Thanks, @timdorr! |
Wonder why the Travis build didn't run here... |
Ah, crap. We should build PRs too. Otherwise we'll never know when it's safe to merge. |
It's my fault |
We do build PRs, but only those against master. This is the rare one not
against master 😄
|
oh, wait. so i didn't need to do this? |
maybe i just need to add |
Yeah, we can whitelist the ones we want. I think you have to change the
Travis file on master. But I'm not a Travis expert :)
|
ok, I'm going to try pushing a modification to .travis.yml to this branch only. Then at least we can see how the build goes before we cut 1.0.3. Sorry for the confusion. |
BTW, the errors we're seeing on Travis I have seen before when going to at least history 1.14.0, so it looks like the behavior of those APIs changed just enough to break the tests. Fixed tests were put in on this PR, so I can replicate that for 1.0.3. |
@timdorr Can you cherry-pick in the test fixes for this PR then? |
Yep, I will. |
I think at least some of the errors were triggered by a bad |
Yeah, since the fact that push/pushState was called with certain args isn't a good test. Testing the effects of that call is a good test. It's better in #2659. |
ok, great. If you can cherry-pick and get the build green let's ship 1.0.3. Thanks, btw :) |
Uh, I hate to be the bearer of bad news, but we missed a warning in 1.16.0. It's still coming up with how |
Bonus points: The warning is backwards. It should be testing that |
Oops. |
If we can push remix-run/history#190 as 1.16.1, all the warnings should go away. But this should be good as-is for now. |
Switch back to a caret range for history
Oops. Finger slipped. This should have been |
Not needed. Once 1.16.1 exists, then this 1.0.3 can be published. |
This should be published as
1.0.3
. Should fix both the warnings fromhistory
(removed in1.16.0
) and any errors about unmet peerDependencies.Also, note this is on the
1.0.x
branch.