Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade flux to version 2.0.1 #280

Merged
merged 1 commit into from
Sep 11, 2014
Merged

upgrade flux to version 2.0.1 #280

merged 1 commit into from
Sep 11, 2014

Conversation

nishp1
Copy link
Contributor

@nishp1 nishp1 commented Sep 11, 2014

facebookarchive/flux#45 also impacts react-router when it is being used with webpack with source maps support.

@mjackson
Copy link
Member

@nishp1 Thanks for the PR! If you would please leave the bumping of versions out, I can just press the merge button! :)

@nishp1
Copy link
Contributor Author

nishp1 commented Sep 11, 2014

Sure @mjackson. Is just reverting the commit okay? Or do you want to me delete the commit all together?

@mjackson
Copy link
Member

Please omit the commit altogether. Thanks!

@mjackson
Copy link
Member

@nishp1 You can do this by just removing that commit from your branch and using git push -f to push the change to GitHub. GitHub will automatically pick up the change and remove that commit from the PR. Just let me know if you need help :)

@nishp1
Copy link
Contributor Author

nishp1 commented Sep 11, 2014

Done!

mjackson added a commit that referenced this pull request Sep 11, 2014
upgrade flux to version 2.0.1
@mjackson mjackson merged commit 16b021a into remix-run:master Sep 11, 2014
@aaronjensen
Copy link
Contributor

Can we get a new release w/ this please?

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants