Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify path style of routercontext.push #2831

Closed
wants to merge 1 commit into from
Closed

clarify path style of routercontext.push #2831

wants to merge 1 commit into from

Conversation

pdeva
Copy link

@pdeva pdeva commented Jan 4, 2016

related to #2829

@taion
Copy link
Contributor

taion commented Jan 4, 2016

This isn't even correct if you're not using hashHistory.

@taion taion closed this Jan 4, 2016
@pdeva
Copy link
Author

pdeva commented Jan 4, 2016

sorry i am confused.
what is wrong there? would be great to know since we really need to use this api and i am running into tons of issues with it, since its clearly not well documented.

@taion
Copy link
Contributor

taion commented Jan 4, 2016

Relative router.push with path-style semantics works when using browser history.

You're probably best off always using absolute paths, but your caveat there is not factually correct.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pdeva @taion