Transition bug #3166
Merged
Transition bug #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving from the first path to the second: /parent/123/child/456 /parent/789/child/456 The route hooks on parent are appropriately called, but not on the child.
|
LGTM Have you had a chance to look at #3108? Seems like you'd need it for data loading as well to pick up on e.g. query changes. |
test is in parent commit
ryanflorence
force-pushed
the
transition-bug
branch
from
23f0e9b
to
d5747e9
Compare
|
I still don't understand why #3108 matters. |
|
|
Let's keep the conversation over there... |
Closed
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/users/123/assignments/456
/users/789/assignments/456
The transition hooks were called on assignments, but not users, now it calls them on both.
If a parent route is left/entered, we should leave and enter all the children regardless of their params. Imagine this exact example when you've got a data loading lib that depends on the leaving/entering routes. You'd see user 123's assignment and not user 789's.