Warn on invalid middlewares #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reactjs/routing How do we feel about the current middleware API? We're well overdue to add some sort of docs, assuming we like it. |
taion
force-pushed
the
warn-invalid-middleware
branch
from
45f41b5
to
f97baca
Compare
|
Is this okay to merge? |
|
I'm not a user of the middleware personally, so I don't feel confident to comment on the API's design. As for the PR, LGTM! |
1 task
Closed
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you pass in a value with properties that is not a valid React Router middleware, we just silently ignore it. This leads to really confusing things happening like relay-tools/react-router-relay#189.
I don't think anybody's intentionally passing in empty objects to
applyRouterMiddleware, so this should be a nice DX convenience.