Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Link): 'to' maybe undefined #4216

Merged
merged 1 commit into from
Nov 25, 2016
Merged

fix(Link): 'to' maybe undefined #4216

merged 1 commit into from
Nov 25, 2016

Conversation

better-owlet
Copy link

No description provided.

@better-owlet better-owlet changed the title 'to' maybe undefined fix(Link): 'to' maybe undefined Nov 25, 2016
@timdorr
Copy link
Member

timdorr commented Nov 25, 2016

Technically, null == undefined in JS. But this reads a little better. Thanks!

@timdorr timdorr merged commit e06190e into remix-run:master Nov 25, 2016
@bancek
Copy link
Contributor

bancek commented Jan 13, 2017

to == null would also match undefined. Now it fails for empty string.

So <Link to=""> doesn't work anymore and has to be replaced with <Link to="/">.

@mjackson
Copy link
Member

Whenever I use to == null, I do it intentionally. It's not the same as !to.

mitranim
mitranim reviewed Mar 6, 2017
View reviewed changes
Copy link

@mitranim mitranim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks to=''

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mitranim mitranim mitranim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@better-owlet @timdorr @bancek @mjackson @mitranim @panzj