Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #4292 #4295

Merged
merged 2 commits into from Dec 19, 2016
Merged

bugfix #4292 #4295

merged 2 commits into from Dec 19, 2016

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2016

withRouter() return wrapped Component if router is not present ([#4292])

Copy link
Member

@timdorr timdorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't bump the version in a PR. Just remove 20e7ae7 and this LGTM.

@timdorr timdorr added the bug label Dec 19, 2016
@timdorr timdorr added this to the v3.0.0 milestone Dec 19, 2016
@timdorr
Copy link
Member

timdorr commented Dec 19, 2016

Also, a test for this would be good to add.

@timdorr
Copy link
Member

timdorr commented Dec 19, 2016

Thanks! Just going to wait on Travis and then merge this in.

@ghost
Copy link
Author

ghost commented Dec 19, 2016

Hey, thats cool, thanks!

@timdorr timdorr merged commit bc66a96 into remix-run:master Dec 19, 2016
@ghost
Copy link
Author

ghost commented Dec 19, 2016

How fast is it usually on npm?

@timdorr
Copy link
Member

timdorr commented Dec 19, 2016

It's whenever someone with publish access does a release. It'll be up there soon.

@ghost
Copy link
Author

ghost commented Dec 19, 2016

Great, thank you!

@thedrew12
Copy link

Is this going to be on npm soon, my tests are breaking.

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants